cli: migrate from urfave/cli/v1 to urfave/cli/v2

[mritunjaysharma394]

Signed-off-by: Mritunjay Sharma mritunjaysharma394@gmail.com

Fixes-262

This PR fixes #262

What

Migrates the Main App from urfave/cli to urfave/cli/v2

Why

Taking advantage of the new version of urfave/cli

How Tested

Locally

[ghost]

CodeSee Review Map:

Review in an interactive map

View more CodeSee Maps

Legend

[kcq]

Thanks a lot for the PR @mritunjaysharma394 ! Quite a lot there :) Nice catch with those BoolTFlag changes too.

[mritunjaysharma394]

Thank you so much for the review and your kind words, @kcq :-)

really means a lot, I will also propose changes to their migrate guide too so that changes like BoolTFlags, Going away of GlobalString, etc and NewStringSlice are reflected there :)

[kcq]

@mritunjaysharma394 Good idea! Their guide definitely needs more info. Now it'll be interesting to see if there are any unexpected gotchas :) I wish they'd still allow the flags anywhere, but in v2 they need to be first.

[mritunjaysharma394]

Yes @kcq, for now I have created a PR for them urfave/cli#1319 and also hoping that we don’t face unexpected gotchas and even if we do, we will solve it :)

thanks for all the help!

[kcq]

nice PR!

[mritunjaysharma394]

Thanks a lot :)