Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for PSR-3 #2937

Merged
merged 4 commits into from Apr 4, 2020
Merged

Add support for PSR-3 #2937

merged 4 commits into from Apr 4, 2020

Conversation

elazar
Copy link
Contributor

@elazar elazar commented Apr 3, 2020

Fixes #2930

@coveralls
Copy link

coveralls commented Apr 3, 2020 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 40eebcd on elazar:feature/psr-log into b8c69e6 on slimphp:4.x.

@l0gicgate l0gicgate added this to the 4.5.0 milestone Apr 3, 2020
l0gicgate
l0gicgate requested changes Apr 4, 2020
View reviewed changes
Copy link
Member

@l0gicgate l0gicgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this PR a lot, thank you for this contribution!

Slim/Logger.php Show resolved Hide resolved
tests/AppTest.php Outdated Show resolved Hide resolved
tests/Middleware/ErrorMiddlewareTest.php Outdated Show resolved Hide resolved
tests/Handlers/ErrorHandlerTest.php Outdated Show resolved Hide resolved
adriansuter
adriansuter approved these changes Apr 4, 2020
View reviewed changes
Copy link
Contributor

@adriansuter adriansuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great piece of work. Just one comment/question. Otherwise, this is good to merge.

Slim/Logger.php Outdated Show resolved Hide resolved
@l0gicgate l0gicgate mentioned this pull request Apr 4, 2020
Closed
@l0gicgate l0gicgate merged commit 8245b0a into slimphp:4.x Apr 4, 2020
@elazar elazar deleted the feature/psr-log branch April 4, 2020 14:23
@odan
Copy link

odan commented Apr 4, 2020

Great 👍 Thank you!

@l0gicgate l0gicgate mentioned this pull request Apr 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0gicgate l0gicgate l0gicgate approved these changes

@adriansuter adriansuter adriansuter approved these changes

Assignees
No one assigned
Labels
Slim 4
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.

PSR-3 support
5 participants
@elazar @coveralls @odan @adriansuter @l0gicgate