Render errors uniformly #2896
Merged
Render errors uniformly #2896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great, thank you for this contribution. |
adriansuter
requested changes
Dec 18, 2019
l0gicgate
reviewed
Dec 18, 2019
|
Travis fails because of |
l0gicgate
reviewed
Dec 20, 2019
|
This PR is good to go. We just need to wait for #2901 to merge |
adriansuter
approved these changes
Dec 20, 2019
|
@adriansuter we could prophesize the tests also instead of using mockbuilder for uniformity. We have time since we have to wait anyway. What do you think? I or you can do it since he probably doesn't know how to |
|
@l0gicgate Why not, uniformity is always a good thing. I think we will have plenty of time indeed - and then there is also Christmas and New Year coming. Feel free to prophesize the mocks. |
* Render error uniformly in different formats * Render http exceptions as custom error pages * Hide backtraces in plain format too
|
I'm locking Prophecy version to 1.9 and merging this. We will address issue in #2901. Won't release 4.4.0 until that's resolved. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR solved several problems