Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove explicit type-hint #2871

Merged
merged 1 commit into from Oct 31, 2019
Merged

Remove explicit type-hint #2871

merged 1 commit into from Oct 31, 2019

Conversation

adriansuter
Copy link
Contributor

The explicit type-hint can be removed as it can be inferred from \Psr\Http\Server\RequestHandlerInterface::handle().

@adriansuter
Remove type-hint
301a182 
The explicit type-hint can be removed as it can be inferred.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 301a182 on adriansuter:patch-type-hint into 534fe00 on slimphp:4.x.

@l0gicgate l0gicgate added this to the 4.4.0 milestone Oct 31, 2019
@l0gicgate l0gicgate merged commit 7f36c9e into slimphp:4.x Oct 31, 2019
@adriansuter adriansuter deleted the patch-type-hint branch October 31, 2019 21:33
@l0gicgate l0gicgate mentioned this pull request Jan 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0gicgate l0gicgate l0gicgate approved these changes

Assignees
No one assigned
Labels
Slim 4
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adriansuter @coveralls @l0gicgate