Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined property in tests #2854

Merged
merged 1 commit into from Oct 3, 2019
Merged

Fix undefined property in tests #2854

merged 1 commit into from Oct 3, 2019

Conversation

piotr-cz
Copy link
Contributor

@piotr-cz piotr-cz commented Oct 1, 2019

This seems like a dead code (tests don't complain) but I see no reason why not fix it.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 14b5c64 on piotr-cz:bugfix/tests-undefined-property into a24fac2 on slimphp:4.x.

@akrabat akrabat closed this in 1257d8c Oct 3, 2019
@akrabat akrabat merged commit 14b5c64 into slimphp:4.x Oct 3, 2019
@piotr-cz piotr-cz deleted the bugfix/tests-undefined-property branch October 3, 2019 10:11
@l0gicgate l0gicgate added this to the 4.3.0 milestone Oct 5, 2019
@l0gicgate l0gicgate mentioned this pull request Oct 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akrabat akrabat akrabat approved these changes

Assignees
No one assigned
Labels
Slim 4
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@piotr-cz @coveralls @akrabat @l0gicgate