4.x - Fix RouteCollectorProxy::redirect() Bug

[l0gicgate]

Fix for #2815

When a container is present the callable gets bound to the container when it's resolved. So the $this context becomes the container and not RouteCollectorProxy anymore.

$handler = function () use ($to, $status) {
    $response = $this->responseFactory->createResponse($status);
    return $response->withHeader('Location', (string) $to);
};

We're using $this->responseFactory() when we should just pass it in via use()

[coveralls]

Coverage remained the same at 100.0% when pulling 5128833 on l0gicgate:FixRedirectBug into 806adf2 on slimphp:4.x.

[adriansuter]

Is there a reason for the container prophecy in the test case? CallableResolver can be used without.

Other than that, everything looks fine. Can't officially approve as my phone app (OctoDroid) has a bug.

[adriansuter]

Ah, should have read the issue. Everything is good!