4.x - Add an advanced callable resolver

[adriansuter]

This PR addresses #2780.

It defines a new AdvancedCallableResolver and a corresponding interface which extends the existing CallableResolverInterface. The advanced callable resolver would be created by default in the App constructor (if none had been passed).

The MiddlewareDispatcher would get the callable resolver as third optional param (non-BC). If it has one, and if the resolver is advanced, then the dispatcher would call the resolveMiddleware method. If the resolver is not advanced or if there is not even a resolver available, the dispatcher would execute its own hard coded resolving.

The \Slim\Routing\Route and the \Slim\Routing\RouteGroup would check if the resolver is advanced. If so, they call resolveRoute to perform the resolving. Otherwise they do as before.

Note: All the test cases for the callable resolver had been copied and implemented for the advanced callable resolver. Some of them were "triplicated", because two had to throw exceptions and one not.

[coveralls]

Coverage remained the same at 100.0% when pulling 1386f93 on adriansuter:patch-callable-resolver into b8d2006 on slimphp:4.x.

[l0gicgate]

@adriansuter that's a really good solution so we entirely avoid any BC breaks. It's also opt-in for developers to implement which is awesome. Great work

[adriansuter]

Okay, there are a lot of changes in the unit tests. I tried to make sure that they test the non-advanced callable resolver as well as the advanced callable resolver.

Two tests did not work as expected. But only if the callable resolver was non-advanced:

• \Slim\Tests\MiddlewareDispatcherTest::testDeferredResolvedClosureIsBoundToContainer
• \Slim\Tests\MiddlewareDispatcherTest::testFetchesMiddlewareFromContainer

Any idea why? I think there is something wrong in the \Slim\MiddlewareDispatcher::addDeferred() -> class::handle() method. Just couldn't find the bug.

[adriansuter]

@l0gicgate Merged your PR. Slim is now using the \Slim\Interfaces\AdvancedCallableResolverInterface for the \Slim\CallableResolver by default.