Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add suggestions for possible PSR-7 implementations to composer.json #2674

Merged
merged 3 commits into from Apr 29, 2019
Merged

Add suggestions for possible PSR-7 implementations to composer.json #2674

merged 3 commits into from Apr 29, 2019

Conversation

michaelbiberich
Copy link
Contributor

References: #2653, specifically this comment.

@michaelbiberich michaelbiberich changed the title Add suggestions for possible PSR-7 implementations to composer.json Add suggestions for possible PSR-7 implementations to composer.json Apr 29, 2019
@coveralls
Copy link

coveralls commented Apr 29, 2019 •
edited

Coverage Status

Coverage remained the same at 99.325% when pulling 249a585 on michaelbiberich:suggestions-for-psr7-implementations into 4b6f030 on slimphp:4.x.

l0gicgate
l0gicgate requested changes Apr 29, 2019
View reviewed changes
Copy link
Member

@l0gicgate l0gicgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should suggest Slim PSR-7 only and provide a link to the docs instead for more repos maybe?

"suggest": {
    "slim/psr7": "Slim PSR-7 implementation. See http://dev.slimframework.com/docs/v4/start/installation.html for more information.",
}

@michaelbiberich
Add suggestions for Slim PSR-7 implementation in composer.json
aa6f672 
References official docs for further information.
@michaelbiberich
Copy link
Contributor Author

The requested changes have been addressed in aa6f672.

l0gicgate
l0gicgate reviewed Apr 29, 2019
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@michaelbiberich
Replace dev URL to docs in suggestion with production URL to docs
249a585 
Will 404 for now but prevent another PR to be created on release of v4.
@l0gicgate
Copy link
Member

Thank you!

@l0gicgate l0gicgate merged commit af2bf95 into slimphp:4.x Apr 29, 2019
@l0gicgate l0gicgate added this to the 4.0.0-beta milestone Apr 29, 2019
@l0gicgate l0gicgate mentioned this pull request May 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0gicgate l0gicgate l0gicgate approved these changes

Assignees
No one assigned
Labels
Slim 4
Projects
None yet
Milestone
4.0.0-beta
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michaelbiberich @coveralls @l0gicgate