Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to unused EnvironmentInterface #2625

Merged
merged 1 commit into from Apr 8, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions Slim/Container.php
Expand Up @@ -21,7 +21,7 @@
* with these service keys configured and ready for use:
*
* - settings: an array or instance of \ArrayAccess
* - environment: an instance of \Slim\Interfaces\Http\EnvironmentInterface
* - environment: an instance of \Slim\Http\Environment
* - request: an instance of \Psr\Http\Message\ServerRequestInterface
* - response: an instance of \Psr\Http\Message\ResponseInterface
* - router: an instance of \Slim\Interfaces\RouterInterface
Expand All @@ -32,7 +32,7 @@
* - callableResolver: an instance of \Slim\Interfaces\CallableResolverInterface
*
* @property-read array $settings
* @property-read \Slim\Interfaces\Http\EnvironmentInterface $environment
* @property-read \Slim\Http\Environment $environment
* @property-read \Psr\Http\Message\ServerRequestInterface $request
* @property-read \Psr\Http\Message\ResponseInterface $response
* @property-read \Slim\Interfaces\RouterInterface $router
Expand Down
5 changes: 2 additions & 3 deletions Slim/DefaultServicesProvider.php
Expand Up @@ -20,7 +20,6 @@
use Slim\Http\Request;
use Slim\Http\Response;
use Slim\Interfaces\CallableResolverInterface;
use Slim\Interfaces\Http\EnvironmentInterface;
use Slim\Interfaces\InvocationStrategyInterface;
use Slim\Interfaces\RouterInterface;

Expand All @@ -39,9 +38,9 @@ public function register($container)
if (!isset($container['environment'])) {
/**
* This service MUST return a shared instance
* of \Slim\Interfaces\Http\EnvironmentInterface.
* of \Slim\Http\Environment.
*
* @return EnvironmentInterface
* @return Environment
*/
$container['environment'] = function () {
return new Environment($_SERVER);
Expand Down