Fix for #2568 #2586
Merged
Fix for #2568 #2586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0gicgate
commented
Feb 20, 2019
akrabat
reviewed
Feb 20, 2019
akrabat
approved these changes
Feb 22, 2019
| @@ -57,3 +57,31 @@ function header($string, $replace = true, $statusCode = null) | |||
| ] | |||
| ); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
We should rename this file now that it containers functions other than header functions. Maybe PhpFunctions.php?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the logic for detecting if user provided router cache file is valid or not.
The following cases are valid:
For the record, if you specify a file that doesn't exist, FastRoute will create it and populate it with the appropriate cache data.
This effectively closes #2568
The PR for the docs is here #334