Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure HEAD requests do not return a body #2576

Merged
merged 6 commits into from Feb 8, 2019

Conversation

lordrhodos
Copy link

Suggests a fix for issue #2386

@akrabat @l0gicgate I need some feedback if this is the right approach

@coveralls
Copy link

coveralls commented Feb 6, 2019

Coverage Status

Coverage increased (+0.006%) to 97.825% when pulling 25470cb on lordrhodos:2386-fix-for-head-requests into 715d130 on slimphp:3.x.

Slim/App.php Outdated Show resolved Hide resolved
Slim/App.php Outdated Show resolved Hide resolved
@l0gicgate
Copy link
Member

A couple of things:

  1. You will need to clear out the existing Response body in App::finalize();
  2. Add the test case from the 4.x branch as seen here

Thank you!

Copy link
Member

@l0gicgate l0gicgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me @lordrhodos. Just need @akrabat to have a glance and we can merge and close #2386.

@l0gicgate l0gicgate added this to the 3.13.0 milestone Feb 8, 2019
@akrabat
Copy link
Member

akrabat commented Feb 8, 2019

Im a little twitchy about using the container's Request object, but it seems the best choice here

@akrabat
Copy link
Member

akrabat commented Feb 8, 2019

Do we need this for Slim 4 too?

@l0gicgate
Copy link
Member

@akrabat I already did this for Slim 4 see #2547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants