Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial MAINTAINERS document #2572

Merged
merged 1 commit into from Jan 23, 2019
Merged

Add initial MAINTAINERS document #2572

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 17 additions & 0 deletions MAINTAINERS.md
View file
Open in desktop
@@ -0,0 +1,17 @@
# Maintainers

There aren't many rules for maintainers of Slim to remember; what we have is listed here.

## We don't merge our own PRs

Our code is better if more than one set of eyes looks at it. Therefore we do not merge our own pull requests unless there is an exceptional circumstance. This helps to spot errors in the patch and also enables us to share information about the project around the maintainer team.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This helps us spot errors in the patch and also enables us to share information about the project with the maintainers team.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(suggested change)


## PRs tagged `WIP` are not ready to be merged

Sometimes it's helpful to collaborate on a patch before it's ready to be merged. We use the text `WIP` (for _Work in Progress_) in the title to mark these PRs.

If a PR has `WIP` in its title, then it is not to be merged. The person who raised the PR will remove the `WIP` text when they are ready for a full review and merge.

## Assign a merged PR to a milestone

By ensuring that all merged PRs are assigned to a milestone, we can easily find which PRs were in which release.