Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added getBasePath method to Router #2519

Merged
merged 1 commit into from Nov 27, 2018
Merged

Added getBasePath method to Router #2519

merged 1 commit into from Nov 27, 2018

Conversation

chantron
Copy link

  • Added docblock for new method
  • Added tests for new method

fixes #1964

@chantron
Added getBasePath method to Router
0b3209b 
* Added docblock for new method
* Added tests for new method
@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 97.815% when pulling 0b3209b on chantron:router-get-base-path into 6d34747 on slimphp:3.x.

@BoGnY
Copy link

BoGnY commented Nov 19, 2018

👍

@BoGnY BoGnY mentioned this pull request Nov 19, 2018
Closed
@akrabat akrabat added this to the 3.12 milestone Nov 27, 2018
@akrabat
Copy link
Member

akrabat commented Nov 27, 2018

Thank you.

@akrabat akrabat merged commit 0b3209b into slimphp:3.x Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.12.0
Development

Successfully merging this pull request may close these issues.

since there is a method named setbasepath in router ,why not have a getter method ?
4 participants
@chantron @coveralls @BoGnY @akrabat