Merge pull request #2630 from chadicus/issue2629

Remove `; charset=utf-8` from Response::withJson() Closes #2629
slimphp · Apr 15, 2019 · 9e1e727 · 9e1e727
2 parents f0718f6 + c311bf2
commit 9e1e727
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Slim/Http/Response.php b/Slim/Http/Response.php
@@ -359,7 +359,7 @@ public function withJson($data, $status = null, $encodingOptions = 0)
             throw new \RuntimeException(json_last_error_msg(), json_last_error());
         }
 
-        $responseWithJson = $response->withHeader('Content-Type', 'application/json;charset=utf-8');
+        $responseWithJson = $response->withHeader('Content-Type', 'application/json');
         if (isset($status)) {
             return $responseWithJson->withStatus($status);
         }

diff --git a/tests/Http/ResponseTest.php b/tests/Http/ResponseTest.php
@@ -292,7 +292,7 @@ public function testWithJson()
 
         $this->assertNotEquals($response->getStatusCode(), $originalResponse->getStatusCode());
         $this->assertEquals(201, $response->getStatusCode());
-        $this->assertEquals('application/json;charset=utf-8', $response->getHeaderLine('Content-Type'));
+        $this->assertEquals('application/json', $response->getHeaderLine('Content-Type'));
 
         $body = $response->getBody();
         $body->rewind();