Merge pull request #3024 from pawel-slowik/randomize-tests

Randomize tests
slimphp · Nov 22, 2020 · 40c1fff · 40c1fff
2 parents 9f6a54f + 7df5918
commit 40c1fff
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 0 deletions.
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -13,6 +13,7 @@
          processIsolation="false"
          stopOnFailure="false"
          bootstrap="tests/bootstrap.php"
+         executionOrder="random"
 >
     <testsuites>
         <testsuite name="Slim Test Suite">

diff --git a/tests/Factory/AppFactoryTest.php b/tests/Factory/AppFactoryTest.php
@@ -84,6 +84,9 @@ public function testDetermineResponseFactoryReturnsDecoratedFactory()
         $this->assertInstanceOf(DecoratedResponseFactory::class, $app->getResponseFactory());
     }
 
+    /**
+     * @runInSeparateProcess - Psr17FactoryProvider::setFactories breaks other tests
+     */
     public function testDetermineResponseFactoryThrowsRuntimeException()
     {
         $this->expectException(RuntimeException::class);
@@ -103,6 +106,9 @@ public function testSetPsr17FactoryProvider()
         $this->assertInstanceOf(SlimResponseFactory::class, AppFactory::determineResponseFactory());
     }
 
+    /**
+     * @runInSeparateProcess - Psr17FactoryProvider::setFactories breaks other tests
+     */
     public function testResponseFactoryIsStillReturnedIfStreamFactoryIsNotAvailable()
     {
         Psr17FactoryProvider::setFactories([MockPsr17FactoryWithoutStreamFactory::class]);
@@ -113,6 +119,9 @@ public function testResponseFactoryIsStillReturnedIfStreamFactoryIsNotAvailable(
         $this->assertInstanceOf(SlimResponseFactory::class, $app->getResponseFactory());
     }
 
+    /**
+     * @runInSeparateProcess - AppFactory::setResponseFactory breaks other tests
+     */
     public function testAppIsCreatedWithInstancesFromSetters()
     {
         $responseFactoryProphecy = $this->prophesize(ResponseFactoryInterface::class);
@@ -166,6 +175,10 @@ public function testAppIsCreatedWithInstancesFromSetters()
         );
     }
 
+    /**
+     * @runInSeparateProcess - AppFactory::create saves $responseFactory into static::$responseFactory,
+     *                         this breaks other tests
+     */
     public function testAppIsCreatedWithInjectedInstancesFromFunctionArguments()
     {
         $responseFactoryProphecy = $this->prophesize(ResponseFactoryInterface::class);
@@ -213,6 +226,9 @@ public function testAppIsCreatedWithInjectedInstancesFromFunctionArguments()
         );
     }
 
+    /**
+     * @runInSeparateProcess - AppFactory::setResponseFactory breaks other tests
+     */
     public function testResponseAndStreamFactoryIsBeingInjectedInDecoratedResponseFactory()
     {
         $responseProphecy = $this->prophesize(ResponseInterface::class);

diff --git a/tests/Factory/Psr17/Psr17FactoryProviderTest.php b/tests/Factory/Psr17/Psr17FactoryProviderTest.php
@@ -15,6 +15,9 @@
 
 class Psr17FactoryProviderTest extends TestCase
 {
+    /**
+     * @runInSeparateProcess - Psr17FactoryProvider::setFactories breaks other tests
+     */
     public function testGetSetFactories()
     {
         Psr17FactoryProvider::setFactories([]);
@@ -23,6 +26,9 @@ public function testGetSetFactories()
     }
 
 
+    /**
+     * @runInSeparateProcess - Psr17FactoryProvider::setFactories breaks other tests
+     */
     public function testAddFactory()
     {
         Psr17FactoryProvider::setFactories(['Factory 1']);

diff --git a/tests/Factory/ServerRequestCreatorFactoryTest.php b/tests/Factory/ServerRequestCreatorFactoryTest.php
@@ -69,6 +69,9 @@ public function testDetermineServerRequestCreatorReturnsDecoratedServerRequestCr
         $this->assertInstanceOf(ServerRequest::class, $serverRequestCreator->createServerRequestFromGlobals());
     }
 
+    /**
+     * @runInSeparateProcess - Psr17FactoryProvider::setFactories breaks other tests
+     */
     public function testDetermineServerRequestCreatorThrowsRuntimeException()
     {
         $this->expectException(RuntimeException::class);
@@ -90,6 +93,9 @@ public function testSetPsr17FactoryProvider()
         $this->assertInstanceOf(SlimServerRequest::class, $serverRequestCreator->createServerRequestFromGlobals());
     }
 
+    /**
+     * @runInSeparateProcess - ServerRequestCreatorFactory::setServerRequestCreator breaks other tests
+     */
     public function testSetServerRequestCreatorWithoutDecorators()
     {
         ServerRequestCreatorFactory::setSlimHttpDecoratorsAutomaticDetection(false);
@@ -108,6 +114,9 @@ public function testSetServerRequestCreatorWithoutDecorators()
         $this->assertSame($serverRequestProphecy->reveal(), $serverRequestCreator->createServerRequestFromGlobals());
     }
 
+    /**
+     * @runInSeparateProcess - ServerRequestCreatorFactory::setServerRequestCreator breaks other tests
+     */
     public function testSetServerRequestCreatorWithDecorators()
     {
         ServerRequestCreatorFactory::setSlimHttpDecoratorsAutomaticDetection(true);