Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove charset on json content-type #105

Merged
merged 2 commits into from Nov 15, 2019
Merged

Remove charset on json content-type #105

merged 2 commits into from Nov 15, 2019

Conversation

odan
Copy link
Contributor

@odan odan commented Nov 15, 2019

Instead of application/json; charset=utf-8, we should simply return application/json without the ; charset=utf-8 suffix.

More details: slimphp/Slim#2629

l0gicgate
l0gicgate requested changes Nov 15, 2019
View reviewed changes
Copy link
Member

@l0gicgate l0gicgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix the tests please

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 85918cb on odan:patch-1 into 433f865 on slimphp:master.

@odan
Copy link
Contributor Author

odan commented Nov 15, 2019

Fixed tests.

@l0gicgate l0gicgate added this to the 0.9 milestone Nov 15, 2019
@l0gicgate l0gicgate merged commit 13e7b70 into slimphp:master Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0gicgate l0gicgate l0gicgate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@odan @coveralls @l0gicgate