Fix TransactionTooLargeException when opening a diff with lots of comments #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but can you please squash the deduplication + type annotation fix commits? |
|
Ok, do you want a single commit for everything or one for the fix + one for the deduplication? |
|
Either is fine. |
Fs00
force-pushed
the
fix-diffs-crash
branch
from
031406f
to
22cd37b
Compare
|
Squashed. |
maniac103
force-pushed
the
fix-diffs-crash
branch
from
22cd37b
to
9fdc2f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash that was occurring when tapping on a file (in PR Files tab) to open the diff in PR PowerShell/PowerShell#9900, caused by a TransactionTooLargeException due to lots of big review comments.
Here I've used the same approach that has been used for the CommitFragment (gzipping the data into the bundle), though I had to write new methods for this specific context. After fixing the issue, I did my best to remove the duplication I had introduced.