-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codecov coverage uploading #308
Conversation
Hmm why didn't CI run my changes to the workflow file? 🤔 |
@filmaj hmm that's super strange. The workflow file changes seem to be noticed but I'd guess the For testing purposes, I'm wondering if changing this to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, you could full send the change! It looks good to me and I'm thinking running this on main
will "just work".
- run: npm ci | ||
- run: npm run build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Ahhh yeah good eye, I think you're right, as doing these kinds of changes in other repos that use |
Summary
Describe the goal of this PR. Mention any related Issue numbers.
Requirements (place an
x
in each[ ]
)