Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to update messages #75 #109

Merged
merged 4 commits into from Jul 27, 2022
Merged

Conversation

kuboon
Copy link
Contributor

@kuboon kuboon commented Jul 22, 2022

Summary

  • add test
  • add usage doc

#75

  • outputs.time was not what I need. Added outputs.ts
  • added update-ts option which calls chat.update api
- id: slack
  uses: slackapi/slack-github-action@v1.18.0
  with:
    channel-id: "#channel"
    payload: |
      {
        "attachments": [
          {
            "pretext": "Deployment started",
            "color": "dbab09",
            "fields": [
              {
                "title": "Status",
                "short": true,
                "value": "In Progress"
              }
            ]
          }
        ]
      }
  env:
    SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN}}
- uses: slackapi/slack-github-action@v1.18.0
  with:
    channel-id: "#channel"
    update-ts: ${{ steps.slack.outputs.ts }}
    payload: |
      {
        "attachments": [
          {
            "pretext": "Deployment finished",
            "color": "28a745",
            "fields": [
              {
                "title": "Status",
                "short": true,
                "value": "Completed"
              }
            ]
          }
        ]
      }
  env:
    SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN}}

Requirements (place an x in each [ ])

@CLAassistant
Copy link

CLAassistant commented Jul 22, 2022

CLA assistant check
All committers have signed the CLA.

@kuboon kuboon marked this pull request as ready for review July 23, 2022 02:25
@seratch seratch added the enhancement New feature or request label Jul 25, 2022
@seratch seratch added this to the 1.20 milestone Jul 25, 2022
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kuboon Thanks a lot for taking the time to work on this feature addition! Once my suggestions on the README changes are resolved, the change looks great to me.

I would like to know what @stevengill @filmaj think about this feature addition (refer to #75 for context) and review this PR!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; Still waiting for others' reviews.

Copy link
Member

@stevengill stevengill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@stevengill stevengill merged commit 18a00ad into slackapi:main Jul 27, 2022
@kuboon kuboon deleted the issue-75 branch August 3, 2022 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants