Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1496 Async client uses blocking call when uploading file with v2 #1498

Merged
merged 1 commit into from
May 16, 2024

Conversation

seratch
Copy link
Member

@seratch seratch commented May 16, 2024

Summary

This pull request resolves #1496

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented web-client Version: 3x area:async labels May 16, 2024
@seratch seratch added this to the 3.27.2 milestone May 16, 2024
@seratch seratch self-assigned this May 16, 2024
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 38.46154% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 85.12%. Comparing base (694ec2f) to head (dd804f4).

Files Patch % Lines
slack_sdk/web/async_client.py 0.00% 4 Missing ⚠️
slack_sdk/web/client.py 0.00% 4 Missing ⚠️
slack_sdk/web/legacy_client.py 0.00% 4 Missing ⚠️
slack_sdk/web/async_base_client.py 50.00% 2 Missing ⚠️
slack_sdk/web/async_internal_utils.py 71.42% 2 Missing ⚠️
slack_sdk/web/base_client.py 50.00% 2 Missing ⚠️
slack_sdk/web/file_upload_v2_result.py 66.66% 2 Missing ⚠️
slack_sdk/web/internal_utils.py 0.00% 2 Missing ⚠️
slack_sdk/web/legacy_base_client.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1498      +/-   ##
==========================================
- Coverage   85.20%   85.12%   -0.08%     
==========================================
  Files         111      112       +1     
  Lines       12291    12316      +25     
==========================================
+ Hits        10472    10484      +12     
- Misses       1819     1832      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seratch seratch merged commit a1c0d3e into slackapi:main May 16, 2024
11 of 12 checks passed
@seratch seratch deleted the issue-1496-async-file-upload branch May 16, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:async bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 3x web-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Async client uses blocking call when uploading file with v2
1 participant