Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit two websocket_client/websockets tests due to their instability on GitHub Actions #1493

Merged
merged 1 commit into from
May 3, 2024

Conversation

seratch
Copy link
Member

@seratch seratch commented May 3, 2024

Summary

The latest minor version of pytest (8.2), which was released a few days ago, affects some of the tests that this project has. So, this pull request locks the version to its previous for now.

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added tests M-T: Testing work only Version: 3x labels May 3, 2024
@seratch seratch added this to the 3.27.2 milestone May 3, 2024
@seratch seratch self-assigned this May 3, 2024
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.18%. Comparing base (f8906fe) to head (83a9832).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1493      +/-   ##
==========================================
- Coverage   85.35%   85.18%   -0.18%     
==========================================
  Files         111      111              
  Lines       12291    12291              
==========================================
- Hits        10491    10470      -21     
- Misses       1800     1821      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seratch seratch changed the title Lock pytest version to 8.1 to avoid instability on GitHub Actions Omit two websocket_client/websockets tests due to their instability on GitHub Actions May 3, 2024
@seratch seratch merged commit 059dd68 into slackapi:main May 3, 2024
12 checks passed
@seratch seratch deleted the pytest-8.2-issue branch May 3, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests M-T: Testing work only Version: 3x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant