Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug where SQLAlchemy based InstallationStore is missing client_id in queries #1354

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

seratch
Copy link
Member

@seratch seratch commented Apr 18, 2023

Summary

This pull reqeust resolves a bug where the SQLAlchemy based installation store does not work properly for multile apps sharing a single database.

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented oauth labels Apr 18, 2023
@seratch seratch added this to the 3.21.2 milestone Apr 18, 2023
@seratch seratch self-assigned this Apr 18, 2023
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #1354 (c5caeb4) into main (bd9c2f5) will not change coverage.
The diff coverage is 100.00%.

❗ Current head c5caeb4 differs from pull request most recent head 76a720e. Consider uploading reports for the commit 76a720e to get more accurate results

@@           Coverage Diff           @@
##             main    #1354   +/-   ##
=======================================
  Coverage   85.37%   85.37%           
=======================================
  Files         111      111           
  Lines       11557    11557           
=======================================
  Hits         9867     9867           
  Misses       1690     1690           
Impacted Files Coverage Δ
...dk/oauth/installation_store/sqlalchemy/__init__.py 98.23% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seratch seratch merged commit 9d9dce0 into slackapi:main Apr 18, 2023
7 checks passed
@seratch seratch deleted the sqlalchemy-installation-store-bug branch April 18, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented oauth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant