Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate deprecated codecov to the latest recommended way #1353

Merged
merged 3 commits into from
Apr 13, 2023

Conversation

seratch
Copy link
Member

@seratch seratch commented Apr 13, 2023

Summary

About 12 hours ago, codecov package was deleted from the PyPI registry as it's no longer supported. This pull request migrates the way to upload the coverage data to the service. In addition to the CI job setting change, I've added a new secret named CODECOV_TOKEN to this repository.

References:

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added this to the 3.21.1 milestone Apr 13, 2023
@seratch seratch self-assigned this Apr 13, 2023
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #1353 (1010771) into main (ee23290) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 1010771 differs from pull request most recent head 540e315. Consider uploading reports for the commit 540e315 to get more accurate results

@@            Coverage Diff             @@
##             main    #1353      +/-   ##
==========================================
- Coverage   85.38%   85.37%   -0.01%     
==========================================
  Files         111      111              
  Lines       11556    11556              
==========================================
- Hits         9867     9866       -1     
- Misses       1689     1690       +1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seratch seratch merged commit b085a4c into slackapi:main Apr 13, 2023
7 checks passed
@seratch seratch deleted the codecov-migration branch April 13, 2023 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant