Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add five admin API supports to Web API clients #1349

Merged
merged 2 commits into from
Apr 7, 2023

Conversation

seratch
Copy link
Member

@seratch seratch commented Apr 7, 2023

Summary

This pull request resolves #1313 and adds the following five missing endpoints to the API clients:

  • admin.roles.addAssignments
  • admin.roles.listAssignments
  • admin.roles.removeAssignments
  • admin.conversations.convertToPublic
  • admin.conversations.lookup

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

- admin.roles.addAssignments
- admin.roles.listAssignments
- admin.roles.removeAssignments
- admin.conversations.convertToPublic
- admin.conversations.lookup
@seratch seratch added enhancement M-T: A feature request for new functionality web-client Version: 3x labels Apr 7, 2023
@seratch seratch added this to the 3.21.0 milestone Apr 7, 2023
@seratch seratch self-assigned this Apr 7, 2023
@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #1349 (a17f7f6) into main (4b200f1) will decrease coverage by 0.05%.
The diff coverage is 80.55%.

@@            Coverage Diff             @@
##             main    #1349      +/-   ##
==========================================
- Coverage   85.47%   85.43%   -0.05%     
==========================================
  Files         111      111              
  Lines       11410    11518     +108     
==========================================
+ Hits         9753     9840      +87     
- Misses       1657     1678      +21     
Impacted Files Coverage Δ
slack_sdk/web/async_client.py 82.33% <80.55%> (-0.07%) ⬇️
slack_sdk/web/client.py 83.59% <80.55%> (-0.11%) ⬇️
slack_sdk/web/legacy_client.py 83.33% <80.55%> (-0.10%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seratch seratch merged commit ec458ee into slackapi:main Apr 7, 2023
3 of 7 checks passed
@seratch seratch deleted the issue-1313-admin-apis branch April 7, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality Version: 3x web-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for admin_roles_{addAssignments|listAssignments|removeAssignments} methods
1 participant