Add file_ids to chat.update parameters #1187
Conversation
seratch
added
bug
| @@ -2448,7 +2453,7 @@ async def conversations_inviteShared( | |||
| else: | |||
| kwargs.update({"emails": emails}) | |||
| if isinstance(user_ids, (list, Tuple)): | |||
| kwargs.update({"emails": ",".join(user_ids)}) | |||
| kwargs.update({"user_ids": ",".join(user_ids)}) | |||
Codecov Report
@@ Coverage Diff @@
## main #1187 +/- ##
==========================================
- Coverage 86.55% 86.53% -0.03%
==========================================
Files 110 110
Lines 10855 10864 +9
==========================================
+ Hits 9396 9401 +5
- Misses 1459 1463 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Looks good! My one comment is that codecov reports some of the type-checking code is not covered by tests, specifically:
- In async_client, if either
file_idsoruser_idsis a list or a Tuple, we should check that the properties are mapped to a comma-delimited string - In the regular client and the legacy_client, if
file_idsis a list of a Tuple, we should that it gets updated to a comma-delimited string
Perhaps we could add those unit tests while we're here?
| @@ -2448,7 +2453,7 @@ async def conversations_inviteShared( | |||
| else: | |||
| kwargs.update({"emails": emails}) | |||
| if isinstance(user_ids, (list, Tuple)): | |||
| kwargs.update({"emails": ",".join(user_ids)}) | |||
| kwargs.update({"user_ids": ",".join(user_ids)}) | |||
|
Hi @filmaj thanks for the comment! As those classes are auto generated, we are okay to skip adding tests. If we want to do so just to gain slightly better coverage rate, it's also fine, though. Let me skip it this time. |
Summary
This pull request adds file_ids to chat.update parameters. Also, it fixes an existing bug in conversations_inviteShared method.
Category (place an
xin each of the[ ])/docs-src(Documents, have you run./scripts/docs.sh?)/docs-src-v2(Documents, have you run./scripts/docs-v2.sh?)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements (place an
xin each[ ])python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.