Skip to content

Commit

Permalink
Add file_ids to chat.update parameters (#1187)
Browse files Browse the repository at this point in the history
  • Loading branch information
seratch committed Feb 24, 2022
1 parent 53766ae commit d0db05a
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 3 deletions.
7 changes: 6 additions & 1 deletion slack_sdk/web/async_client.py
Expand Up @@ -2211,6 +2211,7 @@ async def chat_update(
attachments: Optional[Sequence[Union[Dict, Attachment]]] = None,
blocks: Optional[Sequence[Union[Dict, Block]]] = None,
as_user: Optional[bool] = None,
file_ids: Optional[Union[str, Sequence[str]]] = None,
link_names: Optional[bool] = None,
parse: Optional[str] = None, # none, full
reply_broadcast: Optional[bool] = None,
Expand All @@ -2232,6 +2233,10 @@ async def chat_update(
"reply_broadcast": reply_broadcast,
}
)
if isinstance(file_ids, (list, Tuple)):
kwargs.update({"file_ids": ",".join(file_ids)})
else:
kwargs.update({"file_ids": file_ids})
_parse_web_class_objects(kwargs)
kwargs = _remove_none_values(kwargs)
_warn_if_text_is_missing("chat.update", kwargs)
Expand Down Expand Up @@ -2448,7 +2453,7 @@ async def conversations_inviteShared(
else:
kwargs.update({"emails": emails})
if isinstance(user_ids, (list, Tuple)):
kwargs.update({"emails": ",".join(user_ids)})
kwargs.update({"user_ids": ",".join(user_ids)})
else:
kwargs.update({"user_ids": user_ids})
return await self.api_call(
Expand Down
7 changes: 6 additions & 1 deletion slack_sdk/web/client.py
Expand Up @@ -2160,6 +2160,7 @@ def chat_update(
attachments: Optional[Sequence[Union[Dict, Attachment]]] = None,
blocks: Optional[Sequence[Union[Dict, Block]]] = None,
as_user: Optional[bool] = None,
file_ids: Optional[Union[str, Sequence[str]]] = None,
link_names: Optional[bool] = None,
parse: Optional[str] = None, # none, full
reply_broadcast: Optional[bool] = None,
Expand All @@ -2181,6 +2182,10 @@ def chat_update(
"reply_broadcast": reply_broadcast,
}
)
if isinstance(file_ids, (list, Tuple)):
kwargs.update({"file_ids": ",".join(file_ids)})
else:
kwargs.update({"file_ids": file_ids})
_parse_web_class_objects(kwargs)
kwargs = _remove_none_values(kwargs)
_warn_if_text_is_missing("chat.update", kwargs)
Expand Down Expand Up @@ -2395,7 +2400,7 @@ def conversations_inviteShared(
else:
kwargs.update({"emails": emails})
if isinstance(user_ids, (list, Tuple)):
kwargs.update({"emails": ",".join(user_ids)})
kwargs.update({"user_ids": ",".join(user_ids)})
else:
kwargs.update({"user_ids": user_ids})
return self.api_call(
Expand Down
7 changes: 6 additions & 1 deletion slack_sdk/web/legacy_client.py
Expand Up @@ -2171,6 +2171,7 @@ def chat_update(
attachments: Optional[Sequence[Union[Dict, Attachment]]] = None,
blocks: Optional[Sequence[Union[Dict, Block]]] = None,
as_user: Optional[bool] = None,
file_ids: Optional[Union[str, Sequence[str]]] = None,
link_names: Optional[bool] = None,
parse: Optional[str] = None, # none, full
reply_broadcast: Optional[bool] = None,
Expand All @@ -2192,6 +2193,10 @@ def chat_update(
"reply_broadcast": reply_broadcast,
}
)
if isinstance(file_ids, (list, Tuple)):
kwargs.update({"file_ids": ",".join(file_ids)})
else:
kwargs.update({"file_ids": file_ids})
_parse_web_class_objects(kwargs)
kwargs = _remove_none_values(kwargs)
_warn_if_text_is_missing("chat.update", kwargs)
Expand Down Expand Up @@ -2406,7 +2411,7 @@ def conversations_inviteShared(
else:
kwargs.update({"emails": emails})
if isinstance(user_ids, (list, Tuple)):
kwargs.update({"emails": ",".join(user_ids)})
kwargs.update({"user_ids": ",".join(user_ids)})
else:
kwargs.update({"user_ids": user_ids})
return self.api_call(
Expand Down

0 comments on commit d0db05a

Please sign in to comment.