Fix #1468 RichTextElement.elements items are never promoted to a pr…

…oper Python object type (#1492) Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
slackapi · May 3, 2024 · 694ec2f · 694ec2f
1 parent 059dd68
commit 694ec2f
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 4 deletions.
diff --git a/slack_sdk/models/blocks/block_elements.py b/slack_sdk/models/blocks/block_elements.py
@@ -1868,7 +1868,7 @@ def __init__(
     ):
         super().__init__(type=self.type)
         show_unknown_key_warning(self, others)
-        self.elements = elements
+        self.elements = BlockElement.parse_all(elements)
         self.style = style
         self.indent = indent
         self.offset = offset
@@ -1891,7 +1891,7 @@ def __init__(
     ):
         super().__init__(type=self.type)
         show_unknown_key_warning(self, others)
-        self.elements = elements
+        self.elements = BlockElement.parse_all(elements)
         self.border = border
 
 
@@ -1910,7 +1910,7 @@ def __init__(
     ):
         super().__init__(type=self.type)
         show_unknown_key_warning(self, others)
-        self.elements = elements
+        self.elements = BlockElement.parse_all(elements)
 
 
 class RichTextSectionElement(RichTextElement):
@@ -1928,7 +1928,7 @@ def __init__(
     ):
         super().__init__(type=self.type)
         show_unknown_key_warning(self, others)
-        self.elements = elements
+        self.elements = BlockElement.parse_all(elements)
 
 
 class RichTextElementParts:

diff --git a/tests/slack_sdk/models/test_blocks.py b/tests/slack_sdk/models/test_blocks.py
@@ -1083,3 +1083,38 @@ def test_complex(self):
             ],
         )
         self.assertDictEqual(dict_block, class_block.to_dict())
+
+    def test_elements_are_parsed(self):
+        dict_block = {
+            "type": "rich_text",
+            "elements": [
+                {
+                    "type": "rich_text_section",
+                    "elements": [{"type": "text", "text": "Hello there, I am a basic rich text block!"}],
+                },
+                {
+                    "type": "rich_text_quote",
+                    "elements": [{"type": "text", "text": "this is very important"}],
+                },
+                {
+                    "type": "rich_text_preformatted",
+                    "elements": [{"type": "text", "text": 'print("Hello world")'}],
+                },
+                {
+                    "type": "rich_text_list",
+                    "elements": [
+                        {"type": "rich_text_section", "elements": [{"type": "text", "text": "a"}]},
+                    ],
+                },
+            ],
+        }
+        block = RichTextBlock(**dict_block)
+        self.assertIsInstance(block.elements[0], RichTextSectionElement)
+        self.assertIsInstance(block.elements[0].elements[0], RichTextElementParts.Text)
+        self.assertIsInstance(block.elements[1], RichTextQuoteElement)
+        self.assertIsInstance(block.elements[1].elements[0], RichTextElementParts.Text)
+        self.assertIsInstance(block.elements[2], RichTextPreformattedElement)
+        self.assertIsInstance(block.elements[2].elements[0], RichTextElementParts.Text)
+        self.assertIsInstance(block.elements[3], RichTextListElement)
+        self.assertIsInstance(block.elements[3].elements[0], RichTextSectionElement)
+        self.assertIsInstance(block.elements[3].elements[0].elements[0], RichTextElementParts.Text)