Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widgets #252

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Widgets #252

wants to merge 15 commits into from

Conversation

chrisronline
Copy link

@chrisronline chrisronline commented Nov 28, 2023

Summary

We are adding a new Platform 2.0 primitive called widgets.

Documents

See more in the canvas for #feat-platform-widgets

Testing

Special notes

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've ran deno task test after making the changes.

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.10%. Comparing base (ca8e418) to head (6a8c31a).
Report is 5 commits behind head on main.

❗ Current head 6a8c31a differs from pull request most recent head d095d09. Consider uploading reports for the commit d095d09 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
+ Coverage   98.07%   98.10%   +0.03%     
==========================================
  Files          58       60       +2     
  Lines        2280     2324      +44     
  Branches      137      141       +4     
==========================================
+ Hits         2236     2280      +44     
  Misses         42       42              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

title: string;
description: string;
data_mode: SlackWidgetDataMode;
workflow_id: string;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a string? Or some kind of reference to the workflow? The workflow should exist in the same app

Comment on lines +9 to +10
PER_INSTALLER = "PER_INSTALLER",
PER_USER = "PER_USER",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just updated these to the caps version if it's all the same to you, some slight convenience on my end and matches our API conventions more closely

@@ -1,9 +0,0 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had originally removed this b/c I have a local extension that modifies this, but I see it's actually in main and we probably don't want to remove it.. I'll just deal with it myself for now and maybe ask the SDK folks if we really need it...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added it back.

@chrisronline chrisronline changed the title First pass Widgets Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants