-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widgets #252
base: main
Are you sure you want to change the base?
Widgets #252
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
==========================================
+ Coverage 98.07% 98.10% +0.03%
==========================================
Files 58 60 +2
Lines 2280 2324 +44
Branches 137 141 +4
==========================================
+ Hits 2236 2280 +44
Misses 42 42
Partials 2 2 ☔ View full report in Codecov by Sentry. |
src/manifest/manifest_schema.ts
Outdated
title: string; | ||
description: string; | ||
data_mode: SlackWidgetDataMode; | ||
workflow_id: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a string? Or some kind of reference to the workflow? The workflow should exist in the same app
PER_INSTALLER = "PER_INSTALLER", | ||
PER_USER = "PER_USER", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just updated these to the caps version if it's all the same to you, some slight convenience on my end and matches our API conventions more closely
.vscode/settings.json
Outdated
@@ -1,9 +0,0 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had originally removed this b/c I have a local extension that modifies this, but I see it's actually in main
and we probably don't want to remove it.. I'll just deal with it myself for now and maybe ask the SDK folks if we really need it...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added it back.
Summary
We are adding a new Platform 2.0 primitive called
widgets
.Documents
See more in the canvas for #feat-platform-widgets
Testing
Special notes
Requirements
deno task test
after making the changes.