Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 2020-resolver #745

Merged
merged 1 commit into from Oct 19, 2022
Merged

Remove 2020-resolver #745

merged 1 commit into from Oct 19, 2022

Conversation

WilliamBergamin
Copy link
Contributor

The pip 22.3 release notes mentions that #11493 removed the --use-feature=2020-resolver opt-in flag. This PR removes the instructions that asked contributors to add this flag.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

The 2020-resolver is no longer available in pip 22.3
@WilliamBergamin WilliamBergamin added the docs Improvements or additions to documentation label Oct 19, 2022
@WilliamBergamin WilliamBergamin self-assigned this Oct 19, 2022
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #745 (1cf5fbf) into main (1a3ff44) will not change coverage.
The diff coverage is n/a.

❗ Current head 1cf5fbf differs from pull request most recent head c4d7d65. Consider uploading reports for the commit c4d7d65 to get more accurate results

@@           Coverage Diff           @@
##             main     #745   +/-   ##
=======================================
  Coverage   92.06%   92.06%           
=======================================
  Files         172      172           
  Lines        5875     5875           
=======================================
  Hits         5409     5409           
  Misses        466      466           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seratch seratch added this to the 1.15.3 milestone Oct 19, 2022
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@seratch seratch merged commit 71c89cc into main Oct 19, 2022
@seratch seratch deleted the maintainers-guide-pip branch October 19, 2022 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants