Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Patch] Added call block #897

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KarimNahas
Copy link
Contributor

PR Content:

  • Added call block to the list of accepted blocks.

Note: this is needed to be able to parse Zoom bot messages.

@KarimNahas
Copy link
Contributor Author

@kanata2 Not too sure if I should add any additional tests for this, as call blocks are not really well documented.
Thanks!

@kanata2 kanata2 modified the milestone: v0.9.0 Apr 18, 2021
@petehamilton
Copy link

petehamilton commented Sep 1, 2021

We've done something very similar in our fork 😄 - @kanata2 anything we can do to help get this merged?

@kanata2
Copy link
Member

kanata2 commented Sep 6, 2021

Sorry for my slow response. I'll confirm later.

@petehamilton Thanks for your help 🙏

@sophiekoonin
Copy link

@kanata2 Hey! Would it be possible to get this merged in? We really need it for our project.

@kanata2
Copy link
Member

kanata2 commented Oct 31, 2021

@sophiekoonin I'll confirm later. Sorry for bothering you.

@sophiekoonin
Copy link

@kanata2 Thank you so much ❤️

@zchee zchee self-requested a review February 26, 2022 10:59
@zchee zchee added the feedback given When a review has been conducted and awaiting the response from the comitter(s) label Feb 26, 2022
@zchee
Copy link
Contributor

zchee commented Feb 26, 2022

@KarimNahas Hi, this is newer slack-go maintainer.

I can review it ASAP. So sorry, could you rebase it?

cc: @petehamilton @sophiekoonin

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale label Apr 5, 2023
@kanata2 kanata2 removed the stale label Apr 5, 2023
@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale label May 22, 2023
@kanata2 kanata2 added needs review and removed stale feedback given When a review has been conducted and awaiting the response from the comitter(s) labels May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants