Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connected_team_ids optional field to Conversation #1253

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

zFlabmonsta
Copy link
Contributor

@zFlabmonsta zFlabmonsta commented Jan 20, 2024

Adding connected_team_ids to Conversation struct.

When conversation.info is called, the response comes with a list of team_ids that are connected to the channel. Currently some fields from the response are missing from Conversation struct.

connected_team_ids
internal_team_ids
shared_team_ids
is_global_shared

image

@zFlabmonsta
Copy link
Contributor Author

👋 @parsley42, could i get this pr reviewed 🙇

Copy link
Member

@parsley42 parsley42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look harmful.

@parsley42 parsley42 merged commit 07c76ba into slack-go:master Jan 29, 2024
4 checks passed
@parsley42
Copy link
Member

@zFlabmonsta Ok, this is pretty trivial and obviously not harmful, so I'm ok approving/merging. However, slack-go/slack is not currently actively maintained. I'm not actively developing in Go, so I'm looking for volunteers. Interested?

ymotongpoo pushed a commit to ymotongpoo/opentelemetry-collector-extra that referenced this pull request Jun 4, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/slack-go/slack](https://togithub.com/slack-go/slack) |
`v0.12.3` -> `v0.13.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fslack-go%2fslack/v0.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fslack-go%2fslack/v0.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fslack-go%2fslack/v0.12.3/v0.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fslack-go%2fslack/v0.12.3/v0.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>slack-go/slack (github.com/slack-go/slack)</summary>

###
[`v0.13.0`](https://togithub.com/slack-go/slack/releases/tag/v0.13.0)

[Compare
Source](https://togithub.com/slack-go/slack/compare/v0.12.5...v0.13.0)

> \[!WARNING]\
> This release includes a breaking change since the last release

#### What's Changed

##### Breaking changes

- Expose `team_id` parameter for use with org-wide app by
[@&#8203;candiduslynx](https://togithub.com/candiduslynx) in
[slack-go/slack#1283:
    Changed interface:
    | Old | New |
    | --- | --- |
| `Client.GetBotInfo(bot string) (*Bot, error)` |
`Client.GetBotInfo(parameters GetBotInfoParameters) (*Bot, error)` |
| `Client.GetBotInfoContext(ctx context.Context, bot string)` |
`Client.GetBotInfoContext(ctx context.Context, parameters
GetBotInfoParameters)` |
| `Client.GetTeamProfile() (*TeamProfile, error)` |
`GetTeamProfile(teamID ...string) (*TeamProfile, error)` |
| `GetTeamProfileContext(ctx context.Context) (*TeamProfile, error)` |
`GetTeamProfileContext(ctx context.Context, teamID ...string)
(*TeamProfile, error)` |
| `Client.GetBillableInfo(user string) (map[string]BillingActive,
error)` | `Client.GetBillableInfo(params GetBillableInfoParams)
(map[string]BillingActive, error)` |
| `Client.GetBillableInfoContext(ctx context.Context, user string)
(map[string]BillingActive, error)` | `Client.GetBillableInfoContext(ctx
context.Context, params GetBillableInfoParams)
(map[string]BillingActive, error)` |
| `Client.GetBillableInfoForTeam() (map[string]BillingActive, error)` |
dropped, use `Client.GetBillableInfo` with empty params |
| `Client.GetBillableInfoForTeamContext(ctx context.Context)
(map[string]BillingActive, error)` | dropped, use
`Client.GetBillableInfoContext` with empty params |

##### Bug fixes

- Block Object: Validate text min and max length by
[@&#8203;Chagui-](https://togithub.com/Chagui-) in
[slack-go/slack#1273
- fix some typos by [@&#8203;yutasb](https://togithub.com/yutasb) in
[slack-go/slack#1281

##### Enhancements

- Add missing message option for link_names by
[@&#8203;robbydyer](https://togithub.com/robbydyer) in
[slack-go/slack#1278
- Expose `team_id` parameter for use with org-wide app by
[@&#8203;candiduslynx](https://togithub.com/candiduslynx) in
[slack-go/slack#1283

#### New Contributors

- [@&#8203;Chagui-](https://togithub.com/Chagui-) made their first
contribution in
[slack-go/slack#1273
- [@&#8203;robbydyer](https://togithub.com/robbydyer) made their first
contribution in
[slack-go/slack#1278
- [@&#8203;yutasb](https://togithub.com/yutasb) made their first
contribution in
[slack-go/slack#1281
- [@&#8203;candiduslynx](https://togithub.com/candiduslynx) made their
first contribution in
[slack-go/slack#1283

**Full Changelog**:
slack-go/slack@v0.12.5...v0.13.0

###
[`v0.12.5`](https://togithub.com/slack-go/slack/releases/tag/v0.12.5)

[Compare
Source](https://togithub.com/slack-go/slack/compare/v0.12.4...v0.12.5)

#### What's Changed

BUGFIX - deal with "true", true, "false", false.

- Parse string or boolean for SlashCommand.IsEnterpriseInstall by
[@&#8203;kpaulisse](https://togithub.com/kpaulisse) in
[slack-go/slack#1266

**Full Changelog**:
slack-go/slack@v0.12.4...v0.12.5

###
[`v0.12.4`](https://togithub.com/slack-go/slack/releases/tag/v0.12.4):
Non-breaking updates roll-up

[Compare
Source](https://togithub.com/slack-go/slack/compare/v0.12.3...v0.12.4)

#### What's Changed

- chore: unnecessary use of fmt.Sprintf by
[@&#8203;testwill](https://togithub.com/testwill) in
[slack-go/slack#1212
- Add Video Block by [@&#8203;walkure](https://togithub.com/walkure) in
[slack-go/slack#1210
- Add connected_team_ids optional field to Conversation by
[@&#8203;zFlabmonsta](https://togithub.com/zFlabmonsta) in
[slack-go/slack#1253
- Add blocks in slackevents.MessageEvent by
[@&#8203;invzhi](https://togithub.com/invzhi) in
[slack-go/slack#1227
- Add support for Rich Text Lists by
[@&#8203;daniel-pieper-personio](https://togithub.com/daniel-pieper-personio)
in
[slack-go/slack#1155
- Add support for Rich Text Input by
[@&#8203;peimanja](https://togithub.com/peimanja) in
[slack-go/slack#1240
- Fix: always add context to errors during block serde by
[@&#8203;yunginnanet](https://togithub.com/yunginnanet) in
[slack-go/slack#1259
- Edited field in the app mention event by
[@&#8203;IbirbyZh](https://togithub.com/IbirbyZh) in
[slack-go/slack#1256
- Expose is_enterprise_install field by
[@&#8203;7ail](https://togithub.com/7ail) in
[slack-go/slack#1255
- feat: Add the ability to set `URL` on `NewButtonBlockElement` via
`.WithURL()` by [@&#8203;joshbranham](https://togithub.com/joshbranham)
in
[slack-go/slack#1250
- Add block element type FileInput by
[@&#8203;elct9620](https://togithub.com/elct9620) in
[slack-go/slack#1249
- Openid connect by
[@&#8203;danielmichaels](https://togithub.com/danielmichaels) in
[slack-go/slack#1242
- Add is_enterprise_install flag for org wide installation support by
[@&#8203;hussachai](https://togithub.com/hussachai) in
[slack-go/slack#1225
- Add an example of updating modal by
[@&#8203;KouWakai](https://togithub.com/KouWakai) in
[slack-go/slack#1142
- add deleted timestamp for deleted msg events by
[@&#8203;zFlabmonsta](https://togithub.com/zFlabmonsta) in
[slack-go/slack#1261
- Add slack connect events & tests by
[@&#8203;Birtato](https://togithub.com/Birtato) in
[slack-go/slack#1262
- Add rich_text_quote and rich_text_preformatted by
[@&#8203;rusq](https://togithub.com/rusq) in
[slack-go/slack#1260

#### New Contributors

- [@&#8203;testwill](https://togithub.com/testwill) made their first
contribution in
[slack-go/slack#1212
- [@&#8203;walkure](https://togithub.com/walkure) made their first
contribution in
[slack-go/slack#1210
- [@&#8203;zFlabmonsta](https://togithub.com/zFlabmonsta) made their
first contribution in
[slack-go/slack#1253
- [@&#8203;invzhi](https://togithub.com/invzhi) made their first
contribution in
[slack-go/slack#1227
-
[@&#8203;daniel-pieper-personio](https://togithub.com/daniel-pieper-personio)
made their first contribution in
[slack-go/slack#1155
- [@&#8203;peimanja](https://togithub.com/peimanja) made their first
contribution in
[slack-go/slack#1240
- [@&#8203;yunginnanet](https://togithub.com/yunginnanet) made their
first contribution in
[slack-go/slack#1259
- [@&#8203;IbirbyZh](https://togithub.com/IbirbyZh) made their first
contribution in
[slack-go/slack#1256
- [@&#8203;joshbranham](https://togithub.com/joshbranham) made their
first contribution in
[slack-go/slack#1250
- [@&#8203;elct9620](https://togithub.com/elct9620) made their first
contribution in
[slack-go/slack#1249
- [@&#8203;danielmichaels](https://togithub.com/danielmichaels) made
their first contribution in
[slack-go/slack#1242
- [@&#8203;KouWakai](https://togithub.com/KouWakai) made their first
contribution in
[slack-go/slack#1142
- [@&#8203;Birtato](https://togithub.com/Birtato) made their first
contribution in
[slack-go/slack#1262

**Full Changelog**:
slack-go/slack@v0.12.3...v0.12.4

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/ymotongpoo/opentelemetry-collector-extra).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants