add endpoint to socketmode Clinet and OptionAPIURL function #1198
+10
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Guidelines
These are recommendations for pull requests.
They are strictly guidelines to help manage expectations.
PR preparation
Run
make pr-prep
from the root of the repository to run formatting, linting and tests.Should this be an issue instead
API changes
Since API changes have to be maintained they undergo a more detailed review and are more likely to require changes.
Examples of API changes that do not meet guidelines:
Change points
endpoint
member to SocketMode Clientsocketmode.OptionAPIURL
functionMotivation
I'm creating an application that acts as a server for a Slack App.
To do that, we need to point the Endpoint accessed from slack-go/slack away from
https://api.slack.com
.The slack client provided a way to change the Endpoint URL, while the socketmode client did not. I also found the URL hardcoded in the
openAndDial
function.This PR prepares the same
OptionAPIURL
for socketmode client as for slack client.I would like opinions on whether this change should go into slack-go/slack.