Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Filter Object to Multi Conversation Select Block Element #1191

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Filter Object to Multi Conversation Select Block Element #1191

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
795fde6
add filter object for multi_conversation_select block
imamfzn Apr 10, 2023
d2e84d9
change to ConversationListsFilter for better naming
imamfzn Apr 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions block_element.go
View file
Open in desktop
Expand Up @@ -279,6 +279,7 @@ type MultiSelectBlockElement struct {
InitialChannels []string `json:"initial_channels,omitempty"`
MinQueryLength *int `json:"min_query_length,omitempty"`
MaxSelectedItems *int `json:"max_selected_items,omitempty"`
Filter *SelectBlockElementFilter `json:"filter,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nits]
We should rename to ConversationListsFilter.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kanata2 i've updated to be ConversationListsFilter, kindly help to check again :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Sorry, this suggestion is backward imcompatible change... I'll make new minor version and include this.)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw is there anything that i need to do ? or just waiting for this MR merged by you? @kanata2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge and release as soon as it's ready.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this was a mis-communication; it should be Filter -> ConversationListFilter. We definitely don't want to rename the existing SelectBlockElementFilter. If you want to correct this and the linting issues I'll have another look.

Confirm *ConfirmationBlockObject `json:"confirm,omitempty"`
}

Expand Down