Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for user_profile_changed callback event #1182

Merged
merged 2 commits into from Mar 28, 2023
Merged

add support for user_profile_changed callback event #1182

merged 2 commits into from Mar 28, 2023

Conversation

verygoodsoftwarenotvirus
PR preparation
  • Run make pr-prep from the root of the repository to run formatting, linting and tests.
Should this be an issue instead
  • is it a convenience method? (no new functionality, streamlines some use case)
  • exposes a previously private type, const, method, etc.
  • is it application specific (caching, retry logic, rate limiting, etc)
  • is it performance related.
API changes

n/a

This change allows for the Slack library to parse incoming callback events of the user_profile_changed type. Previously, parseInnerEvent threw an error because it didn't have record of this event type.

Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kanata2 kanata2 merged commit e2fef23 into slack-go:master Mar 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants