Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove omitempty from replace_original and delete_orginal #1122

Merged
merged 1 commit into from Nov 4, 2022
Merged

fix: remove omitempty from replace_original and delete_orginal #1122

merged 1 commit into from Nov 4, 2022

Conversation

yokishava
Copy link
Contributor

why

I saw the issue on #1063 and fixed it.

what

  • I removed omitempty in replaceOriginal and deleteOriginal in webhookmessage.
  • I made a few changes to the webhookmessage test.

kanata2
kanata2 approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kanata2 kanata2 added bugfix [PR] bugfix Web API labels Nov 4, 2022
@kanata2 kanata2 merged commit c99b47b into slack-go:master Nov 4, 2022
@kanata2 kanata2 mentioned this pull request Nov 4, 2022
Closed
@yokishava yokishava deleted the fix/replace-original-omitemtpy branch November 4, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanata2 kanata2 kanata2 approved these changes

Assignees
No one assigned
Labels
bugfix [PR] bugfix Web API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yokishava @kanata2