Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create multipart form when multipart request #1117

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

EkeMinusYou
Copy link

@EkeMinusYou EkeMinusYou commented Oct 23, 2022

This PR fixs form parameter format when multipart request.

@kanata2
Copy link
Member

kanata2 commented Oct 31, 2022

@EkeMinusYou
Could you add an explanation of what the problem is with the current implementation, or a link to the issue?

@kanata2 kanata2 added the feedback given When a review has been conducted and awaiting the response from the comitter(s) label Oct 31, 2022
@EkeMinusYou
Copy link
Author

@kanata2
It is not clearly described in Slack's API documentation and is difficult to explain.

https://api.slack.com/methods/files.remote.add

However, when I checked the actual behavior, it seems that in the case of mutlipart request, the parameters must be put in the body instead of the query. Otherwise the token cannot be passed and authentication will fail.

@kanata2 kanata2 removed the feedback given When a review has been conducted and awaiting the response from the comitter(s) label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants