Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sharedLinks struct should be exported #1080

Merged
merged 3 commits into from Sep 11, 2022
Merged

sharedLinks struct should be exported #1080

merged 3 commits into from Sep 11, 2022

Conversation

pmenglund
Copy link
Contributor

Fixes #1079 - breaks API compatibility as a struct is exported, but I assume it was not intended to be unexported.

kanata2
kanata2 reviewed Jul 5, 2022
View reviewed changes
Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

slackevents/inner_events_test.go Outdated Show resolved Hide resolved
@kanata2 kanata2 added api cleanup feedback given When a review has been conducted and awaiting the response from the comitter(s) labels Jul 5, 2022
@kanata2 kanata2 removed the feedback given When a review has been conducted and awaiting the response from the comitter(s) label Jul 6, 2022
kanata2
kanata2 approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

Actually, I think this changes don't break user's applications by updating slack-go, so maybe okay to release in the next patch version.

@kanata2 kanata2 merged commit 78e593a into slack-go:master Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanata2 kanata2 kanata2 approved these changes

Assignees
No one assigned
Labels
api cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

slackevents.sharedLinks struct is unexported
2 participants
@pmenglund @kanata2