Support "reply_broadcast" parameter in webhook API #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjaxu
force-pushed
the
reply-broadcast-webhook
branch
from
377fc72
to
a6124c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Slack's Webhook API actually supports the
"reply_broadcast"parameter when sending replies, just like itschat.postMessageAPI although it's not documented explicitly in its webhook API docs. (I discovered it while working on a Slack bot for work).The webhook SDK currently doesn't support this (it's only supported in
PostMessageParameters), so I would like to add this to theWebhookMessagestruct as well so it can be used for webhooks.Note:
The default value of this parameter is
falsewhen not specified, so there won't be any breaking changes.Hopefully, this can get accepted so I can start using the SDK over raw HTTP requests.
Thanks!