Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uniformize event_ts support on inner events #1052

Merged
merged 3 commits into from Jun 2, 2022
Merged

Uniformize event_ts support on inner events #1052

merged 3 commits into from Jun 2, 2022

Commits on Apr 11, 2022

  1. Add missing EventTimestamp field on some inner events

    @abustany
    abustany committed Apr 11, 2022
    Copy the full SHA
    93bc872 View commit details
    Browse the repository at this point in the history

  2. Make WorkflowStepExecuteEvent.EventTimestamp name consistent with the… 

    … other events

The fields used to be called EventTS, but WorkflowStepExecuteEvent was
the only event struct with such a field.
    @abustany
    abustany committed Apr 11, 2022
    Copy the full SHA
    179dac2 View commit details
    Browse the repository at this point in the history

  3. Don't use json.Number to encode/decode events event_ts 

    This field should always be stored/used as a string according to [1].
This also makes the type more consistent across events.

[1] slackhq/slack-api-docs#7 (comment)
    @abustany
    abustany committed Apr 11, 2022
    Copy the full SHA
    6361adf View commit details
    Browse the repository at this point in the history