Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Details field to Audit event entries #1047

Merged
merged 6 commits into from Apr 23, 2022
Merged

Conversation

JustinJudd
Copy link
Contributor

Added the optional details field for the audit events. As there aren't details what all of the sub-fields are, adding different fields that we've seen in our logs.

Added the optional `details` field for the audit events. As there aren't details what all of the sub-fields are, adding different fields that we've seen in our logs.
Added Details field to Audit event entries
@zchee zchee self-requested a review March 23, 2022 01:52
@zchee
Copy link
Contributor

zchee commented Mar 23, 2022

@JustinJudd Could you run make fmt?

@JustinJudd
Copy link
Contributor Author

Sorry about that. Formatted.

Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't confirm some fields in Java SDK's implementation.

  • policy_name
  • authentication_mode
  • entity_ids
  • succeeded_users
  • failed_users

As I mentioned in #1038, we don't have a way to verify Enterprise Grid API's behavior.
If these fields are not essential to your use case, we can merge them as soon as you remove them. How about it?

audit.go Show resolved Hide resolved
audit.go Outdated Show resolved Hide resolved
@kanata2 kanata2 added the feedback given When a review has been conducted and awaiting the response from the comitter(s) label Apr 16, 2022
Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kanata2 kanata2 merged commit 835fab1 into slack-go:master Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feedback given When a review has been conducted and awaiting the response from the comitter(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants