Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return ScheduledMessageID everywhere #1046

Closed

Conversation

mfine
Copy link

@mfine mfine commented Mar 22, 2022

Should this be an issue instead
  • is it a convenience method? (no new functionality, streamlines some use case)
  • exposes a previously private type, const, method, etc.
  • is it application specific (caching, retry logic, rate limiting, etc)
  • is it performance related.
API changes

This extends SendMessage* to return scheduled_message_id everywhere. It would be great if the impact of this change could be smaller, but the common SendMessage* functionality is used everywhere so needed to be extended everywhere it was used. If there's a better way to expose scheduled_message_id in a more limited fashion, that would be great.

Fixes #757

Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More than 4 or 5 return values for a public function/method is too many,
so we would like to consider some other approach.

@kanata2
Copy link
Member

kanata2 commented Apr 16, 2022

@zchee What do you think?

@kanata2 kanata2 added the feedback given When a review has been conducted and awaiting the response from the comitter(s) label Apr 16, 2022
@pankona
Copy link

pankona commented Jun 30, 2022

@kanata2 @zchee
Hello, I'm a one of waiting for release of this patch. I'm afraid to say that I'm happy if you proceed this pull request. Thanks!

@hussachai
Copy link
Contributor

hussachai commented Dec 20, 2022

Isn't scheduled message ID applicable to SendScheduledMessage API only? And messageTs is applicable to only SendMessage API. IMO, this change makes it more confusing, and I personally don't like multi-values-return that returns more than 2 values because it's hard to know which one is what without a name. I'd replicate SendMessageContext for scheduled API maybe name it ScheduleMessageContext and returns scheduled message ID in the position of message TS. The better approach would be refactoring the API to reduce the duplication in code which is not much to reduce anyway. Just my 2 cents from the user who is waiting for this.
PS. I have my own a fork version which supports this. My function returns only 2 values instead of 3 like SendMessageContext because I don't know why we need to get a channel ID back when the channel ID is a already known since it is one of function arguments. I don't mind keeping it consistent, but either cases, this will be a breaking change unless we have a new function (the hard part will be naming it :)) and deprecate the old one.

@hussachai
Copy link
Contributor

I proposed the fix for this in the least intrusive way here #1153

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale label Apr 5, 2023
@github-actions
Copy link

This PR was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking changes enhancement feedback given When a review has been conducted and awaiting the response from the comitter(s) stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing scheduled_message_id
5 participants