Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow_step: add SaveWorkflowStepConfigurationConetxt & fix return err #1042

Merged
merged 1 commit into from Mar 11, 2022

Conversation

zchee
Copy link
Contributor

@zchee zchee commented Mar 11, 2022

Add SaveWorkflowStepConfigurationConetxt which added by #1027, and fix return err.

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
@zchee zchee requested a review from kanata2 March 11, 2022 05:49
@zchee zchee self-assigned this Mar 11, 2022
@zchee
Copy link
Contributor Author

zchee commented Mar 11, 2022

@kanata2 self merge.

@zchee zchee merged commit 90b1ed4 into master Mar 11, 2022
@zchee zchee deleted the 1027-ctx-aware branch March 11, 2022 06:00
return api.SaveWorkflowStepConfigurationConetxt(context.Background(), workflowStepEditID, inputs, outputs)
}

func (api *Client) SaveWorkflowStepConfigurationConetxt(ctx context.Context, workflowStepEditID string, inputs *WorkflowStepInputs, outputs *[]WorkflowStepOutput) error {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zchee,

there is a little typo in apt.SaveWorkflowStepConfigurationConetxt()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be ...Context()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah... fix ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants