Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: add new //go:build lines #1032

Merged
merged 1 commit into from Feb 13, 2022
Merged

all: add new //go:build lines #1032

merged 1 commit into from Feb 13, 2022
+2 −0

Conversation

zchee
Copy link
Contributor

@zchee zchee commented Feb 13, 2022

Add new //go:build lines.

$ go version
go version go1.17.7 darwin/amd64

$ make fmt
# have diffs

@zchee
all: add new //go:build lines
7f6b224 
$ go version
go version go1.17.7 darwin/amd64

$ make fmt

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
kanata2
kanata2 approved these changes Feb 13, 2022
View reviewed changes
Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
(Actually, we no longer support v1.12, so we should delete webhooks_go112.go 😆 )

@kanata2 kanata2 merged commit 1bc0bcc into slack-go:master Feb 13, 2022
@zchee zchee deleted the go117-buildtag branch February 13, 2022 13:23
@zchee zchee mentioned this pull request Feb 14, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanata2 kanata2 kanata2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zchee @kanata2