optimize slackutilsx.EscapeMessage function

slack-go · Mar 9, 2022 · 60ea6a8 · 60ea6a8
1 parent f6658aa
commit 60ea6a8
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/slackutilsx/slackutilsx.go b/slackutilsx/slackutilsx.go
@@ -50,10 +50,12 @@ func DetectChannelType(channelID string) ChannelType {
 	}
 }
 
+// initialize replacer only once (if needed)
+var escapeReplacer = strings.NewReplacer("&", "&amp;", "<", "&lt;", ">", "&gt;")
+
 // EscapeMessage text
 func EscapeMessage(message string) string {
-	replacer := strings.NewReplacer("&", "&amp;", "<", "&lt;", ">", "&gt;")
-	return replacer.Replace(message)
+	return escapeReplacer.Replace(message)
 }
 
 // Retryable errors return true.

diff --git a/slackutilsx/slackutilsx_test.go b/slackutilsx/slackutilsx_test.go
@@ -28,3 +28,9 @@ func TestEscapeMessage(t *testing.T) {
 	test("A < B", "A &lt; B")
 	test("A > B", "A &gt; B")
 }
+
+func BenchmarkEscapeMessage(b *testing.B) {
+	for i := 0; i < b.N; i++ {
+		EscapeMessage("A & B")
+	}
+}