-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple public source page #4930
Simple public source page #4930
Conversation
…blish one source. #1
…rceId' to improve clarity. #1
…ep_public_source_pages_cache. #1
…te and to store the data we will pass to the public page. #1
…added to the cache. #1
…rce page link to it. #1
… information if we publish or unpublish in the payload. #1
…ce_accessibility table of a source when the private page is loaded. #1
…ish button executes a PATCH to update the source_accessibility and if it does not exist on database it sends to the POST methode to create one. Rename of the 'published' cache field to public. #1
…in for "See public page" link. #1
…eThumbnails.jsx to ThumbnailsOnPage.jsx. Create files for component Thumbnail.jsx and for ThumbnailsOnPage.jsx and add them to the 'thumbnail' folder. Update all project import link to it.
…simple_public_source_page
…e.jsx to the function which generate the template in models/source_accessibility.py. #1
…e to create the photometry plot. Passage of photometry data from the source page to the creation of the template. Renaming of data passed from the source page and used when creating the public template from data_to_display to public_data. #1
…ation of a style.css file with the general style common to all public pages. #1
…mbnailList.jsx and in Source.jsx when get the data to send the public page template generation. #1
…ch is not displayed and addition of style. #1
…lic_pages, rename the source template and update import. #1
…for the cache use by public gcn report page. #1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments, mostly asking some questions to make sure I understand some of the changes
@antoine-le-calloch migrations were fixed on main if you want to merge your branch with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super simple comments, otherwise I am happy with this version as a V1!
@Theodlz @mcoughlin. Last corrections have been made. |
I'm about to merge your PR @antoine-le-calloch, any chance to resolve the conflicts that are on main super quick? No worries if you can't do it now, just let me know and I'll take care of it. |
I'm doing it now ! |
Done! |
The purpose of this issue is to make a private source page public by generating simple html that will be added to the cache and made available to the public. And in addition to display a public page with all the souces and versions of this source currently in a public mode.
Version 1