Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Github Actions to python 3.10 and fixed following issues #556

Merged
merged 5 commits into from Oct 15, 2021

Conversation

asenyaev
Copy link
Contributor

@asenyaev asenyaev commented Oct 7, 2021

Also fixes the issue #525

@mattip
Copy link

mattip commented Oct 8, 2021

Please replace the multibuild/xenial_arm64v8 testing image with multibuild/focal_arm64v8

@asenyaev
Copy link
Contributor Author

asenyaev commented Oct 8, 2021

@mattip, there is Python 3.10.0rc1 in the multibuild/focal_arm64v8 image. I think tests will pass with it, but could you update this image to the released python version (Python 3.10.0)?

@mattip
Copy link

mattip commented Oct 8, 2021

The image will be updated by multi-build/docker-images#19. I would suggest moving to focal on all but 32 bit linux, which is no longer supported by Ubuntu.

@asenyaev
Copy link
Contributor Author

asenyaev commented Oct 8, 2021

@mattip, I have already changed the docker image to focal. Thank you!

Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Copy link
Collaborator

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@egeakman
Copy link

Looking good 👍

@cclauss
Copy link
Contributor

cclauss commented Oct 14, 2021

120 passing tests! What else needs to be done to land this and release to PyPI?

@asenyaev asenyaev self-assigned this Oct 15, 2021
@asenyaev asenyaev merged commit 69be49c into opencv:master Oct 15, 2021
@alalek
Copy link
Member

alalek commented Oct 16, 2021

Please add "3.10" version item right after "Programming Language :: Python :: 3.9"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants