Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade testing to Python 3.10.0 production release #4396

Closed
wants to merge 16 commits into from
Closed

Upgrade testing to Python 3.10.0 production release #4396

wants to merge 16 commits into from

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented May 4, 2021

https://www.python.org/download/pre-releases/

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@cclauss cclauss requested a review from dhruvmanila as a code owner May 4, 2021 10:56
@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass labels May 4, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label May 6, 2021
@cclauss
Copy link
Member Author

cclauss commented May 6, 2021

Selective execution of tests means that a PR can be all green when the build GitHub Action fails. :-(

@cclauss cclauss closed this May 12, 2021
@cclauss cclauss reopened this May 12, 2021
@ghost ghost added the tests are failing Do not merge until tests pass label May 12, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Jun 2, 2021
@stale
Copy link

stale bot commented Jul 8, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added stale Used to mark an issue or pull request stale. and removed stale Used to mark an issue or pull request stale. labels Jul 8, 2021
@cclauss cclauss changed the title WIP: Do not merge -- Test on Python 3.10 beta 1 WIP: Do not merge -- Test on Python 3.10 beta 3 Jul 8, 2021
@ghost ghost added the tests are failing Do not merge until tests pass label Jul 8, 2021
@cclauss cclauss changed the title WIP: Do not merge -- Test on Python 3.10 beta 3 WIP: Do not merge -- Test on Python 3.10 beta 4 Jul 11, 2021
@cclauss cclauss changed the title WIP: Do not merge -- Test on Python 3.10 beta 4 WIP: Do not merge -- Test on Python 3.10 release candidate 1 Aug 4, 2021
@stale
Copy link

stale bot commented Sep 6, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Sep 6, 2021
@cclauss cclauss removed the stale Used to mark an issue or pull request stale. label Sep 6, 2021
@ghost ghost added merge conflicts Open a new PR or rebase on the latest commit tests are failing Do not merge until tests pass and removed merge conflicts Open a new PR or rebase on the latest commit tests are failing Do not merge until tests pass labels Sep 6, 2021
@cclauss cclauss changed the title WIP: Do not merge -- Test on Python 3.10 release candidate 1 WIP: Do not merge -- Test on Python 3.10 release candidate 2 Sep 8, 2021
@cclauss cclauss changed the title WIP: Do not merge -- Test on Python 3.10 release candidate 2 Upgrade testing to Python 3.10.0 production release Oct 5, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 5, 2021
@poyea
Copy link
Member

poyea commented Oct 5, 2021

Seems that there's a dependency issue?

@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Oct 5, 2021
@cclauss cclauss marked this pull request as draft October 5, 2021 16:09
@cclauss
Copy link
Member Author

cclauss commented Oct 5, 2021 •
edited

Yes. opencv-python is not yet compatible with Python 3.10. opencv/opencv-python#525 —> opencv/opencv-python#556

@ghost ghost added the merge conflicts Open a new PR or rebase on the latest commit label Oct 29, 2021
@ghost ghost removed the merge conflicts Open a new PR or rebase on the latest commit label Nov 4, 2021
@cclauss cclauss mentioned this pull request Feb 12, 2022
Merged
15 tasks
@cclauss
Copy link
Member Author

cclauss commented Feb 12, 2022

Closing in favor of #5992

@cclauss cclauss closed this Feb 12, 2022
@dhruvmanila dhruvmanila deleted the Python-3.10-beta-1 branch October 1, 2022 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

@onlinejudge95 onlinejudge95 Awaiting requested review from onlinejudge95

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed DO-NOT-MERGE enhancement This PR modified some existing files tests are failing Do not merge until tests pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cclauss @poyea @dhruvmanila