-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] pykan based forecaster #6386
Conversation
TODOs
|
How do I install from sktime.forecasting.pykan_forecaster import PyKANForecaster, what is the dependency to install? |
Hey, it is not on the main branch yet. You need to install the feature branch. E.g. by cloning the repo check out the feature branch and install this branch. Hopefully, this feature is included in the next sktime release. |
let me know when it's ready to review - currently there is one unchecked todo |
Sorry, I forgot to tick the open todo. I enabled the parameter using two dicts: model_params and fit_params |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems done, then.
Have you solved the test time issue?
Thank you very much @fkiraly Franz Király excellent work,, I'm going to try it. a query to perform some tests I must clone the repository, and then I can call the function like this: from sktime.forecasting.pykan_forecaster import PyKANForecaster |
@narencastellon, this is actually almost entirely @benHeid's work! To use this, you can simply wait for the release 0.29.1 in a few days, I would assume it is by then merged. |
Not checked it directly, but due to the set test params and rather small test time series I haven't experienced any long test runs. Furthermore, also the CI forecasting runs are not reporting this forecaster as slowest. |
I compared it with the cINNForecaster. After reducing the network size of the test network it is now a bit faster than the cINNForecaster. |
I have updated and cloned sktime with 0.29.1, and I want to apply the pykan_forecaster example: from sktime.forecasting.pykan_forecaster import PyKANForecaster but it sends me the following error "TypeError: 'NoneType' object is not subscriptable" |
The issue is that the grid param is not set and that I haven't set sensible defaults... So the following code should work: from sktime.forecasting.pykan_forecaster import PyKANForecaster
forecaster = PyKANForecaster(grids=[5,5])
forecaster.fit(df, fh = 12) regarding the problem you identified. Might you open an issue, so that this can be tracked and fixed? |
Towards #6390
Reference Issues/PRs
#6390
What does this implement/fix? Explain your changes.
Add a simple PyKAN based forecaster
Does your contribution introduce a new dependency? If yes, which one?
pykan
What should a reviewer concentrate their feedback on?
Did you add any tests for the change?
add get_test_params
Any other comments?
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
sktime
root directory (not theCONTRIBUTORS.md
). Common badges:code
- fixing a bug, or adding code logic.doc
- writing or improving documentation or docstrings.bug
- reporting or diagnosing a bug (get this pluscode
if you also fixed the bug in the PR).maintenance
- CI, test framework, release.See here for full badge reference
maintainers
tag - do this if you want to become the owner or maintainer of an estimator you added.See here for further details on the algorithm maintainer role.
For new estimators
docs/source/api_reference/taskname.rst
, follow the pattern.Examples
section.python_dependencies
tag and ensureddependency isolation, see the estimator dependencies guide.