-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Address deprecated references in datatypes module #2082
Conversation
@gchhablani, I took the liberty of fixing a linting error to get the tests to run, hope that's ok |
@fkiraly Thank a lot! I missed that 😥 |
This PR looks quite promising actually. It covers much more that what I did here: #2339. It should definitely be revitalized. |
@gchhablani What do you mean "a possibility"? The issue is still open. Warnings are all over the place. Your PR seem to be resolving a lot of them. So why did you stop? |
I would also appreciate getting this PR merged. The warnings are quite "verbose"... |
I have partially addressed those warnings in #2339, but this PR seem to be more comprehensive. |
@khrapovs I was distracted by other things, but I can continue working on this one and get it merged asap. Just wanted to check with you if that is okay. |
@@ -138,8 +144,8 @@ def test_check_fh_values_duplicate_input_values(arg): | |||
ForecastingHorizon(arg) | |||
|
|||
|
|||
GOOD_ABSOLUTE_INPUT_ARGS = ( | |||
pd.Int64Index([1, 2, 3]), | |||
GOOD_INPUT_ARGS = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also have to rename the variable in line 151
This PR can be closed. The issue #2332 is resolved. Sorry, @gchhablani, these warnings were too annoying. |
yes, I think they are, and this is now heavily conflicting. Thanks a lot for your work, @gchhablani. |
Reference Issues/PRs
Fixes #2049.
What does this implement/fix? Explain your changes.
In this fix, I:
pd.Int64Index
across all files.pd.Index
anddtype=='int64'
.pd.Int64Index(...)
topd.Index(..., dtype='int64')
.Does your contribution introduce a new dependency? If yes, which one?
NA
What should a reviewer concentrate their feedback on?
Any other comments?
pre-commit
was failing. I have added the docstrings as well. If it needs to be added in a separate PR, please let me know.PR checklist
For all contributions
I've added unit tests and made sure they pass locally