Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/gh actions windows spec failure #140

Merged
merged 4 commits into from
Apr 27, 2024
Merged

Conversation

skoji
Copy link
Owner

@skoji skoji commented Apr 26, 2024

No description provided.

@skoji skoji force-pushed the fix/gh-actions-windows-spec-failure branch from d27aaba to e3c7aa8 Compare April 26, 2024 09:06
@skoji skoji force-pushed the fix/gh-actions-windows-spec-failure branch 4 times, most recently from cc7e454 to 3422cff Compare April 27, 2024 05:53
@skoji skoji force-pushed the fix/gh-actions-windows-spec-failure branch from 3422cff to 07e8d72 Compare April 27, 2024 05:57
@skoji skoji merged commit 8c9f437 into main Apr 27, 2024
36 checks passed
@slonopotamus
Copy link
Contributor

slonopotamus commented May 12, 2024

I suspect, some of gepub changes cause this issue. I think that gepub stopped properly closing file descriptor, that's why deletion fails on Windows.

I'm also observing this in asciidoctor-epub3 test suite: https://github.com/asciidoctor/asciidoctor-epub3/actions/runs/9051436682/job/24867956933#step:5:488

  32) Asciidoctor::Epub3::Converter - Xref resolves xref to inline anchor
      Failure/Error: output.generate_epub target

      Errno::EACCES:
        Permission denied - D:/a/asciidoctor-epub3/asciidoctor-epub3/spec/temp/book.epub
      # ./vendor/bundle/jruby/3.1.0/gems/gepub-1.0.16/lib/gepub/book.rb:233:in `generate_epub'
      # ./lib/asciidoctor-epub3/converter.rb:19:in `write'
      # ./vendor/bundle/jruby/3.1.0/gems/asciidoctor-2.0.22/lib/asciidoctor/document.rb:989:in `write'
      # ./vendor/bundle/jruby/3.1.0/gems/asciidoctor-2.0.22/lib/asciidoctor/convert.rb:124:in `convert'
      # ./vendor/bundle/jruby/3.1.0/gems/asciidoctor-2.0.22/lib/asciidoctor/convert.rb:190:in `block in convert_file'
      # ./vendor/bundle/jruby/3.1.0/gems/asciidoctor-2.0.22/lib/asciidoctor/convert.rb:190:in `convert_file'
      # ./spec/spec_helper.rb:72:in `convert'
      # ./spec/spec_helper.rb:79:in `to_epub'
      # ./spec/xref_spec.rb:30:in `block in <main>'

Note that gepub 1.0.15 passes without issues: https://github.com/slonopotamus/asciidoctor-epub3/actions/runs/9051508194/job/24868104673

As a workaround, I currently locked gepub to 1.0.15 in asciidoctor-epub3: asciidoctor/asciidoctor-epub3#474

@slonopotamus
Copy link
Contributor

Created #141 for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants